Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WFS3 overlapping text template #43363

Merged

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented May 24, 2021

Fixes: #42269

immagine

Candidate for immediate BP: it is a small HTML template change.

@elpaso elpaso added Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server backport release-3_16 labels May 24, 2021
@github-actions github-actions bot added this to the 3.20.0 milestone May 24, 2021
@pathmapper
Copy link
Contributor

Looks good, thank you.

@elpaso
Copy link
Contributor Author

elpaso commented May 25, 2021

@pathmapper did you know that you can easily customize and override the HTML templates? I'm not sure we documented that enough.

@pathmapper
Copy link
Contributor

pathmapper commented May 25, 2021

@elpaso not before I had a look at your PR :)

I think it's already well documented but I just didn't notice it:
https://docs.qgis.org/3.16/en/docs/server_manual/services.html#the-html-template-language

grafik

Having the word "Customize" in the title and thereby in the table of content on the left side of the docs page would be good.
Maybe change the existing title "The HTML template language" -> "Customize and override the HTML templates" ?

I could make a PR to the docs repo if wanted.

Edit: or just "Customize the HTML templates" to make it shorter.

Edit2: or "Customize the HTML pages"

@elpaso
Copy link
Contributor Author

elpaso commented May 25, 2021

@pathmapper yes please, do whatever it takes to make it clearer.

@elpaso elpaso merged commit 0ee907d into qgis:master May 25, 2021
@elpaso elpaso deleted the bugfix-gh42269-wfs3-getfeature-overlapping-text branch May 25, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server: WFS3/API Features - overlapping columns/content on data items as HTML pages
3 participants