Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix D&D GPKG from browser #43436

Merged
merged 1 commit into from
May 28, 2021

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented May 28, 2021

Fixes #43129

@elpaso elpaso added Bug Either a bug report, or a bug fix. Let's hope for the latter! QGIS Browser labels May 28, 2021
@github-actions github-actions bot added this to the 3.20.0 milestone May 28, 2021
@elpaso
Copy link
Contributor Author

elpaso commented May 28, 2021

@agiudiceandrea can you please test this PR?

@elpaso elpaso added the backport queued_ltr_backports Queued Backports label May 28, 2021
@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented May 28, 2021

@elpaso both the main issue #43129 and the additional issue #43129 (comment) are fixed with this PR (anyway the "Invalid Layer" critical error message still show up).

Thank you.

@nyalldawson nyalldawson merged commit 32af68f into qgis:master May 28, 2021
@qgis-bot
Copy link
Collaborator

The backport to queued_ltr_backports failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-43436-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 3de9f49427e279bf6302b74db4e475572b0230a3
# Push it to GitHub
git push --set-upstream origin backport-43436-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports

Then, create a pull request where the base branch is queued_ltr_backports and the compare/head branch is backport-43436-to-queued_ltr_backports.

@elpaso elpaso removed the backport queued_ltr_backports Queued Backports label May 31, 2021
@elpaso elpaso deleted the bugfix-gh43129-fix-gpkg-dd-browser branch May 31, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! QGIS Browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser adds layers to projects with a leading space
5 participants