Add missing NoButton enum value to avoid losing relation editor button configuration #43479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionEditorWidget also remove leftover
…sFlagsValueToKeys fixes qgis#43123
domi4484
approved these changes
Jun 1, 2021
nirvn
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buttons config has been moved from
QgsAttributeEditorRelationtoQgsRelationEditorWidget. The logic is that the buttons are a configuration of the default implementation of relation editor (we now have a registry for these).The enum had to be duplicated in the two classes, I added some documentation to the enums to reflect this and deprecated the former one.
To fix the issue, I added a NoButton (key = 0) to the enum entries, and it works perfectly.
Fixes #43123