[Geometry checker] Fix the error resolution ui. Fixes #42489 #43550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
method.id() always returns 0, I put back the old mechanism which works.
m-kuhn
approved these changes
Jun 4, 2021
|
Thanks @lbartoletti, now it's possible to correctly save the preferred error resolution method settings. |
|
thanks @lbartoletti for the fix @agiudiceandrea for testing |
lbartoletti
deleted the
fix_geometry_checker_default_error_resolutions_settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
method.id() always returns 0, I put back the old mechanism which works.
For users who have already used the tool, there may be a small conflict in the preferences of this interface. However, once the new settings are saved, there is no problem.
cc @agiudiceandrea