-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Oracle] Use QgsTask to retrieve available tables so we can properly cancel it #43587
Conversation
This is a GREAT move! I'd love to see the other providers doing this too at some stage. |
3fa8582
to
33b9f2d
Compare
33b9f2d
to
ec84beb
Compare
…so we can properly cancel it
ec84beb
to
136381c
Compare
@nyalldawson Everything is green, is it OK to merge? |
@nyalldawson gentle ping, is it OK to merge? |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-43587-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 136381c8e45397d3fb118aa6491ea8f200fab12a
# Push it to GitHub
git push --set-upstream origin backport-43587-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports Then, create a pull request where the |
Fixes #40001 : Use QgsTask instead of Qthread so we can properly cancel it from QgsTaskManagerWidget and when quitting the application.
For the record, createChildren is called inside a thread which is destroyed at the end of the function, so we need to move the task to the main thread so the sent signals/events have a QEventLoop running to process them.