New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #41903 point cloud crash on macos #43743

Merged

wonder-sk merged 2 commits into qgis:master from PeterPetrik:fix_41903

Jun 16, 2021

Contributor

PeterPetrik commented Jun 15, 2021 •

edited

Loading

actually 2 problems found introduced 19e4617

return std::get<1>( n1 ) >= std::get<1>( n1 ); is copy-paste error
sort needs strict weak ordering https://stackoverflow.com/questions/18291620/why-will-stdsort-crash-if-the-comparison-function-is-not-as-operator/18291727#18291727


          fix qgis#41903 point cloud crash on macos

579a09e

PeterPetrik assigned wonder-sk

github-actions bot added this to the 3.20.0 milestone


          fix linux compilation

decd69b

wonder-sk approved these changes

View reviewed changes

wonder-sk merged commit 7263d67 into qgis:master

PeterPetrik deleted the fix_41903 branch

October 19, 2021 06:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment