Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the ticket configuration on GitHub #44033

Merged
merged 2 commits into from Jul 27, 2021
Merged

Review the ticket configuration on GitHub #44033

merged 2 commits into from Jul 27, 2021

Conversation

Gustry
Copy link
Contributor

@Gustry Gustry commented Jul 2, 2021

Description

There is also a new feature in github to create "form" : https://github.blog/changelog/2021-06-23-issues-forms-beta-for-public-repositories/
I have'n looked yet at these forms.

CC @DelazJ @gioman

@github-actions github-actions bot added this to the 3.22.0 milestone Jul 2, 2021
@m-kuhn
Copy link
Member

m-kuhn commented Jul 7, 2021

Does this change anything or is it just cleaning up the files?
Happy to merge but missing a tiny bit of context here.

@Gustry
Copy link
Contributor Author

Gustry commented Jul 7, 2021

Yes, it is updating a little bit.
It means you can't open tickets without a label. You also can't open a ticket for a external plugin.

My master branch was not up to date (missing the QGIS plugin entry), but I tried there first : https://github.com/Gustry/QGIS/issues/new/choose

Copy link
Contributor

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Gustry for the delay and thanks for the explanation (that I also missed). A good idea imho. So no more won't fix generated issue?

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@gioman
Copy link
Contributor

gioman commented Jul 7, 2021

@Gustry sorry for the late reply, I missed the notification. Great improvement! Also if we could turn the template into a form would be really really great. I will look into it too.

@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 22, 2021
@gioman gioman removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 22, 2021
@Gustry
Copy link
Contributor Author

Gustry commented Jul 24, 2021

New version available for preview on my fork : https://github.com/Gustry/QGIS/issues/new/choose

@DelazJ I have updated about the documentation : desktop versus c++/pyqgis

@gioman
Copy link
Contributor

gioman commented Jul 24, 2021

New version available for preview on my fork : https://github.com/Gustry/QGIS/issues/new/choose

@Gustry nice!

@m-kuhn
Copy link
Member

m-kuhn commented Jul 24, 2021

Nice !

image

I would suggest to

  • rename "C++ or PyQGIS Documentation" to "API documentation (C++ or PyQGIS)"
  • rename "Documentation on the desktop or server side" to "Documentation (desktop and server)" and adapt the description to "Suggest improvements or report errors regarding https://docs.qgis.org"

@Gustry
Copy link
Contributor Author

Gustry commented Jul 24, 2021

Updated.

Still the preview on my fork : https://github.com/Gustry/QGIS/issues/new/choose

Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of merging this, we can fine tune later on.
Thanks a lot !

@nirvn
Copy link
Contributor

nirvn commented Jul 24, 2021

Merge at will!

@m-kuhn m-kuhn enabled auto-merge July 24, 2021 11:06
auto-merge was automatically disabled July 24, 2021 11:32

Head branch was pushed to by a user without write access

@Gustry
Copy link
Contributor Author

Gustry commented Jul 24, 2021

In the meantime, I have check how to have a form : https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

So files have switched to YML instead of markdown.

You can have a look to the form preview on my fork, link above.

Copy link
Contributor

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Gustry .

@rldhont rldhont closed this Jul 26, 2021
@rldhont rldhont reopened this Jul 26, 2021
@Gustry
Copy link
Contributor Author

Gustry commented Jul 26, 2021

This PR is only changing the .github folder so CI is not relevant. Some other workflows are still required and pending for this PR.

@m-kuhn
Copy link
Member

m-kuhn commented Jul 26, 2021

I guess those other workflows are not triggered because the paths don't match (https://github.com/qgis/QGIS/blob/master/.github/workflows/run-tests.yml#L9-L17) but they are still required.

@3nids do you see a solution for that (other than removing the path filter)?

@3nids 3nids closed this Jul 27, 2021
@3nids 3nids reopened this Jul 27, 2021
@3nids
Copy link
Member

3nids commented Jul 27, 2021

@m-kuhn builds are currently failing on Fedora with Qt6 and tests are not run. I recently fixed this by always making the tests run.

@Gustry
Copy link
Contributor Author

Gustry commented Jul 27, 2021

Can someone (with admin rights) merge manually ?

@m-kuhn m-kuhn merged commit 33671c1 into qgis:master Jul 27, 2021
@Gustry Gustry deleted the tickets branch July 27, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants