Database connection utility #44200
Merged
Database connection utility #44200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @nyalldawson since you asked for it 😸 |
nyalldawson
reviewed
Jul 18, 2021
Replace DB Manager legend custom menu action with C++ implementation for SQL layer
elpaso
force-pushed
the
database-connection-utility
branch
from
bca3cf4
to
0edd64f
Compare
nyalldawson
approved these changes
Jul 22, 2021
stefanuhrig
reviewed
Aug 4, 2021
| * \throws QgsProviderConnectionException if any errors are encountered or if SQL layer creation is not supported. | ||
| * \since QGIS 3.22 | ||
| */ | ||
| virtual SqlVectorLayerOptions sqlOptions( const QString &layerSource ) SIP_THROW( QgsProviderConnectionException ); |
There was a problem hiding this comment.
@mrylov We should implement that for HANA as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #44051 by adding more methods and tests and replaces DB Manager custom legend action for SQL layers with C++ implementation.