Avoid recursion in crs validation #44349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If some proj helper files are missing (likely proj.db), showing the projection selection dialog is shown recursively. Avoid this. Excerpt from a sample trace: ``` QgsMapLayer::setCrs : QgsVectorLayer::setCoordinateSystem : QgsVectorLayer::setDataSource : QgsVectorLayer::QgsVectorLayer : QgsCoordinateBoundsPreviewMapWidget::QgsCoordinateBoundsPreviewMapWidget : QgsProjectionSelectionTreeWidget::setShowNoProjection : QgsProjectionSelectionTreeWidget::QgsProjectionSelectionTreeWidget : QgsProjectionSelectionDialog::setShowNoProjection : QgsProjectionSelectionDialog::QgsProjectionSelectionDialog : QgisApp::validateCrs : QObject::qt_static_metacall : QgisApp::customCrsValidation : QgisApp::customProjection : QgsMapLayer::setCrs : QgsVectorLayer::setCoordinateSystem : QgsVectorLayer::setDataSource : QgsVectorLayer::QgsVectorLayer : QgsCoordinateBoundsPreviewMapWidget::QgsCoordinateBoundsPreviewMapWidget : QgsProjectionSelectionTreeWidget::setShowNoProjection : QgsProjectionSelectionTreeWidget::QgsProjectionSelectionTreeWidget : QgsProjectionSelectionDialog::setShowNoProjection : QgsProjectionSelectionDialog::QgsProjectionSelectionDialog : QgisApp::validateCrs : QObject::qt_static_metacall : QgisApp::customCrsValidation : QgisApp::customProjection : QgsMapLayer::setCrs : QgsVectorLayer::setCoordinateSystem : QgsVectorLayer::setDataSource : QgsVectorLayer::QgsVectorLayer : QgsCoordinateBoundsPreviewMapWidget::QgsCoordinateBoundsPreviewMapWidget : QgsProjectionSelectionTreeWidget::setShowNoProjection : QgsProjectionSelectionTreeWidget::QgsProjectionSelectionTreeWidget : QgsProjectionSelectionDialog::setShowNoProjection : QgsProjectionSelectionDialog::QgsProjectionSelectionDialog : QgisApp::validateCrs : QObject::qt_static_metacall : QgisApp::customCrsValidation : QgisApp::customProjection : QgsMapLayer::setCrs : QgsVectorLayer::setCoordinateSystem : QgsVectorLayer::setDataSource : QgsVectorLayer::QgsVectorLayer : QgsCoordinateBoundsPreviewMapWidget::QgsCoordinateBoundsPreviewMapWidget : QgsProjectionSelectionTreeWidget::setShowNoProjection : QgsProjectionSelectionTreeWidget::QgsProjectionSelectionTreeWidget : QgsProjectionSelectionDialog::setShowNoProjection : QgsProjectionSelectionDialog::QgsProjectionSelectionDialog : QgisApp::validateCrs : QObject::qt_static_metacall : QgisApp::customCrsValidation : ```
elpaso
approved these changes
Jul 23, 2021
|
Yes, I evaluated some alternatives, this one seemed to be the least intrusive and most straightforward one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some proj helper files are missing (likely proj.db), showing the
projection selection dialog is shown recursively. Avoid this.
Excerpt from a sample trace:
Description
[Replace this with some text explaining the rationale and details about this pull request]