Fix Save for external ressource dialog RelativeStorage config parameter

[troopa81]

Fixes #44799 : When clicking on "ok" button, mRelativeGroupBox is not visible because its parent is not visible anymore. This PR changes the condition so it works all the time

[domi4484]

QGIS/src/gui/editorwidgets/qgsexternalresourceconfigdlg.cpp

Line 181 in 543831d

cfg.insert( QStringLiteral( "StorageMode" ), mStorageModeGroupBox->isVisible() ?

here isVisible is also used as condition. Is that not a little dangerous to? would it maybe be better to use the combo box index instead?
btw. thank you for the fix!

[troopa81]

here isVisible is also used as condition. Is that not a little dangerous to? would it maybe be better to use the combo box index instead?

Yes, you're right. Done

[nyalldawson]

@troopa81

here isVisible is also used as condition. Is that not a little dangerous to? would it maybe be better to use the combo box index instead?

Just to expand on this -- we've had issues when people have used isVisible() for this kind of thing before because that will always be FALSE when the dialog is saving properties as a result of it being closed!

[nyalldawson]

(it'd be valuable to do a scan on other uses of isVisible throughout the codebase to see if other widget properties are using this too!)