Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gdal sample identify/sample precision issue #45086

Merged

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Sep 16, 2021

Fixes #44902 plus an unreported crash

@elpaso elpaso added Rasters Related to general raster layer handling (not specific data formats) Data Provider Related to specific vector, raster or mesh data providers Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Sep 16, 2021
@github-actions github-actions bot added this to the 3.22.0 milestone Sep 16, 2021
@elpaso elpaso added the backport queued_ltr_backports Queued Backports label Sep 16, 2021
@nyalldawson nyalldawson merged commit 6039ded into qgis:master Sep 17, 2021
@qgis-bot
Copy link
Collaborator

The backport to queued_ltr_backports failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-45086-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick b381abb79a1095dfca8a398197f6457e031e9a60,c59cffbfd160a6e2fe8cd03c40d193d2b11bf906
# Push it to GitHub
git push --set-upstream origin backport-45086-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports

Then, create a pull request where the base branch is queued_ltr_backports and the compare/head branch is backport-45086-to-queued_ltr_backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport queued_ltr_backports Queued Backports Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers Rasters Related to general raster layer handling (not specific data formats)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sample() and identify() from QgsRasterDataProvider don't always provide the same value
3 participants