Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix face/vertex count during editing #45142

Merged
merged 2 commits into from Sep 21, 2021

Conversation

vcloarec
Copy link
Member

During mesh editing, some faces and vertices can be void and are still in the mesh until the end of editing or a re indexing. When the count of faces or vertices are requested to the mesh layer, the return value includes all the elements, even the void one. That leads to a false information for the user, for example in the mesh layer properties (information tab).

With this PR, only the non void faces /vertices are included in the count.

@vcloarec vcloarec added the Mesh Related to general mesh layer handling (not specific data formats) label Sep 20, 2021
@github-actions github-actions bot added this to the 3.22.0 milestone Sep 20, 2021
src/core/mesh/qgsmesheditor.h Outdated Show resolved Hide resolved
src/core/mesh/qgsmesheditor.h Outdated Show resolved Hide resolved
@PeterPetrik PeterPetrik merged commit ef2f404 into qgis:master Sep 21, 2021
@vcloarec vcloarec deleted the verticesFacesCount branch October 8, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mesh Related to general mesh layer handling (not specific data formats)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants