Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a crash when adding a single point to multi #45157

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Sep 20, 2021

Fixes #45152

@elpaso elpaso added Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality labels Sep 20, 2021
@github-actions github-actions bot added this to the 3.22.0 milestone Sep 20, 2021
@elpaso elpaso force-pushed the bugfix-gh45153-fix-crash-when-adding-point-to-multi branch from 3ad27a6 to f63df11 Compare September 20, 2021 12:21
@nirvn
Copy link
Contributor

nirvn commented Sep 20, 2021

Any chance we could add a test case to catch the regression if it ever re-emerges?

Thanks for the swift response time :)

@elpaso
Copy link
Contributor Author

elpaso commented Sep 20, 2021

Any chance we could add a test case to catch the regression if it ever re-emerges?

Thanks for the swift response time :)

Let's wait for @lbartoletti opinion, I'm not very familiar with digitizing tests, I'll wait for his advice.

@lbartoletti
Copy link
Member

Any chance we could add a test case to catch the regression if it ever re-emerges?
Thanks for the swift response time :)

Let's wait for @lbartoletti opinion, I'm not very familiar with digitizing tests, I'll wait for his advice.

Thanks @elpaso

+1 with @nirvn unfortunately multigeometries are not tested. And especially multipoint in tests/src/app/maptooladdfeaturepoint/testqgsmaptooladdfeaturepoint.cpp

…oint.cpp

Co-authored-by: Loïc Bartoletti <lbartoletti@users.noreply.github.com>
@nyalldawson
Copy link
Collaborator

@elpaso can you fix the astyle issue here? Seems I can't push direct to your branch to fix myself

@elpaso
Copy link
Contributor Author

elpaso commented Sep 25, 2021

@elpaso can you fix the astyle issue here? Seems I can't push direct to your branch to fix myself

I've added you to my fork, just in case you'd need it again in the future.

@nyalldawson nyalldawson enabled auto-merge (rebase) September 26, 2021 22:21
@nyalldawson nyalldawson merged commit 6a57fd0 into qgis:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a new point onto a memory multipoint layer kills QGIS
4 participants