Geometry Checker: Enlarge FeatureID #45191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbartoletti
added
backport queued_ltr_backports
|
@lbartoletti I was wondering, why is it exported as a string in the first place? |
IDK, but I suspect a problem with a limitation of int on platform/file format/system. Maybe @manisandro has a better explanation? |
|
I don't recall TBH, possibly it was a client requirement at the time. |
nyalldawson
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FeatureID is an int64 from -9223372036854775808 to 9223372036854775807 and is saved as a string in the plugin. However string(10) is too short.