Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QgisApp::closeProject(): cancel canvas jobs before closing the project, ... #45227

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Sep 23, 2021

... to avoid rendering jobs to access deleted objects (fixes #44144)

(upstream laz-perf has changed much from our copy and doesn't seem to
have that flow)
@rouault rouault added Bug Either a bug report, or a bug fix. Let's hope for the latter! backport queued_ltr_backports Queued Backports labels Sep 23, 2021
@github-actions github-actions bot added this to the 3.22.0 milestone Sep 23, 2021
…t, to avoid rendering jobs to access deleted objects (fixes qgis#44144)
@qgis-bot
Copy link
Collaborator

The backport to queued_ltr_backports failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-45227-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 96cdfb101be50341b0b827ec52678684bc9ccae0,fa5a9eeae969b54cb1f0b1bcfdb2d9f7d58d5bef
# Push it to GitHub
git push --set-upstream origin backport-45227-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports

Then, create a pull request where the base branch is queued_ltr_backports and the compare/head branch is backport-45227-to-queued_ltr_backports.

@rouault
Copy link
Contributor Author

rouault commented Sep 24, 2021

Manually backported in #45241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport queued_ltr_backports Queued Backports Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in QgsPointCloudLayerRenderer when closing while rendering still active
3 participants