Use correct schema URL for xsi:schemaLocation for WFS 1.1.0 GetCapabilities response

[pathmapper]

Description

Before:

This PR:

[pathmapper]

Test failure seems unrelated:

99% tests passed, 1 tests failed out of 759

Total Test time (real) = 1454.42 sec

The following tests FAILED:
	 13 - ProcessingQgisAlgorithmsTestPt4 (Failed)
File "/tmp/tmpqum_7uzs/highlight_lines.png" not found.
255
File "/tmp/tmpgfjmf7r3/highlight_polygons.png" not found.
	Add file: /root/QGIS/.ci/config_test.ctest
	Add file: /root/QGIS/build/CMakeCache.txt

[pblottiere]

Hello @pathmapper,

Thanks for your recent work on WFS 1.X 👍. I'm just going to run OGC TeamEngine on this PR to check if we're going in the right direction.

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[pathmapper]

Just run the OGC TeamEngine on this PR (WFS-Basic):

There's no difference in the test results compared to the status before this PR. Looks like the schema URL for xsi:schemaLocation is not covered by TeamEngine tests.

This PR:

Before this PR:

[pblottiere]

Just run the OGC TeamEngine on this PR (WFS-Basic):

Oh nice, thanks for taking a look @pathmapper 👍! But something seems to be missing because the wfs:run-GetCapabilities-basic-cc-GET should not be failing: http://test.qgis.org/ogc_cite/wfs_110/2021_10_10_05_00/report.html.

I'm (finally) compiling your branch.

[pathmapper]

But something seems to be missing

@pblottiere thanks for taking a look, too. This is not related to this PR.

It's related to the QGIS test project I'm using for the TeamEngine test, there's no WMSContactOrganization specified, so the mandatory ows:ProviderName is missing in the GetCapabilities response.

QGIS/src/server/services/wfs/qgswfsgetcapabilities.cpp

Lines 247 to 255 in 248b32f

	//ProviderName
	const QString contactOrganization = QgsServerProjectUtils::owsServiceContactOrganization( *project );
	if ( !contactOrganization.isEmpty() )
	{
	QDomElement providerNameElem = doc.createElement( QStringLiteral( "ows:ProviderName" ) );
	const QDomText providerNameText = doc.createTextNode( contactOrganization );
	providerNameElem.appendChild( providerNameText );
	serviceElem.appendChild( providerNameElem );
	}

QGIS/src/server/qgsserverprojectutils.cpp

Lines 90 to 93 in 41f0918

	QString QgsServerProjectUtils::owsServiceContactOrganization( const QgsProject &project )
	{
	return project.readEntry( QStringLiteral( "WMSContactOrganization" ), QStringLiteral( "/" ) );
	}

We should use a fallback like "Unknown" for QgsServerProjectUtils::owsServiceContactOrganization to make sure ows:ProviderName is always included in the GetCapabilities response.

Looks like this applies to WMTS GetCapabilities response as well:

QGIS/src/server/services/wmts/qgswmtsgetcapabilities.cpp

Lines 184 to 191 in 97884ad

	const QString contactOrganization = QgsServerProjectUtils::owsServiceContactOrganization( *project );
	if ( !contactOrganization.isEmpty() )
	{
	QDomElement contactOrganizationElem = doc.createElement( QStringLiteral( "ows:ProviderName" ) );
	const QDomText contactOrganizationText = doc.createTextNode( contactOrganization );
	contactOrganizationElem.appendChild( contactOrganizationText );
	serviceElem.appendChild( contactOrganizationElem );
	}

I'm happy to submit a PR for this. Currently not sure if ows:ProviderName must always be included in the GetCapabilities response.

[pblottiere]

Hello @pathmapper,

I ran the WFS 1.1.0 testsuite and I didn't notice any changes (neither improvement nor degradation).

Can you rebase please? Then I'll merge your PR.

Thanks a lot for your patience 👍

[pathmapper]

Can you rebase please?

Thanks @pblottiere, done.