Don't overwrite existing data defined property expressions when an interactive map tool is used to move/rotate/edit labels #45279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QgsAuxiliaryLayer::createProperty(*)
Instead, if a property already exists it will be upgraded to
an expression based property of the form:
coalesce("new aux field", 'existing' || 'property' || 'expression')
(i.e. allow per-feature value overrides from the auxiliary field,
but by default fallback to the existing property definition)
Refs qgis#44475
properties of the form coalesce("new aux field", 'some' || 'expression')
Refs qgis#44475
an interactive map tool is used to move/rotate/edit labels
But instead automatically upgrade this property to use a
coalesce("aux field", 'existing' || 'property' || 'expression')
type expression, so that the tool will place the interactively
edited position/rotation/etc in the auxiliary field but default
to using the expression for all other features
Fixes qgis#44475
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But instead automatically upgrade this property to use a
type expression, so that the tool will place the interactively edited position/rotation/etc in the auxiliary field but default to using the expression for all other features
Fixes #44475