-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take query parameters for url advertised in capabilities from the original request #45376
Conversation
…ginal request url. Fix advertised url if QGIS Server is accessed by rewrite rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, does this deserve a test (mainly to protect for accidental changes)?
Yes, a unit test makes sense here. Going to add it |
…abilities are taken from original request
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist. |
I'm reopening this PR because I think this bug might be a problem for a lot of productive deployments of QGIS Server |
@m-kuhn, why both queued_ltr_backport and release-3_22 branchee backports? |
Shaky hands after too long a conference day 😵💫😜 |
If QGIS Server is accessed by a rewrite-rule, the original request usually does not contain the map parameter, however the rewritten request does. To decide if the map-parameter has to be added to the url advertised in GetCapabilities, the original request has to be considered (not the rewritten request).