Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take query parameters for url advertised in capabilities from the original request #45376

Merged
merged 4 commits into from
Feb 3, 2022

Conversation

mhugent
Copy link
Contributor

@mhugent mhugent commented Oct 4, 2021

If QGIS Server is accessed by a rewrite-rule, the original request usually does not contain the map parameter, however the rewritten request does. To decide if the map-parameter has to be added to the url advertised in GetCapabilities, the original request has to be considered (not the rewritten request).

…ginal request url. Fix advertised url if QGIS Server is accessed by rewrite rule
@mhugent mhugent requested a review from sbrunner October 4, 2021 12:05
@github-actions github-actions bot added this to the 3.22.0 milestone Oct 4, 2021
Copy link
Contributor

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does this deserve a test (mainly to protect for accidental changes)?

@mhugent
Copy link
Contributor Author

mhugent commented Oct 4, 2021

LGTM, does this deserve a test (mainly to protect for accidental changes)?

Yes, a unit test makes sense here. Going to add it

@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 20, 2021
@nyalldawson nyalldawson added Frozen Feature freeze - Do not merge! and removed Frozen Feature freeze - Do not merge! labels Oct 21, 2021
@github-actions
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Oct 30, 2021
@mhugent
Copy link
Contributor Author

mhugent commented Jan 31, 2022

I'm reopening this PR because I think this bug might be a problem for a lot of productive deployments of QGIS Server

@mhugent mhugent reopened this Jan 31, 2022
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 31, 2022
@agiudiceandrea
Copy link
Contributor

@m-kuhn, why both queued_ltr_backport and release-3_22 branchee backports?

@m-kuhn
Copy link
Member

m-kuhn commented Oct 20, 2022

Shaky hands after too long a conference day 😵‍💫😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants