Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature #6562] add editable option for all edit types #455

Merged
merged 2 commits into from Mar 10, 2013

Conversation

3nids
Copy link
Member

@3nids 3nids commented Mar 4, 2013

I have added an option to define if a field is editable or not by the user.

I know there was the immutable edit type but, this property is more a field property than a proper edit type. Indeed, value relations, ranges or checkboxes could not be disabled before.

I have not removed the immutable type since the edit types are saved as numbers (and not text) in the project.
I would propose to change this. But for compatibility, we would have to create some translation methods (int->string, string->int) to traduce the enum type to the name of the edit type.
Discussion's open!

@ghost ghost assigned jef-n Mar 7, 2013
@3nids
Copy link
Member Author

3nids commented Mar 8, 2013

Here is a screenshot of the edit type dialog

Screenshot from 2013-03-08 10:26:39

@NathanW2
Copy link
Member

NathanW2 commented Mar 8, 2013

Hey Denis,

Nice work. I will merge this for you tonight.

Here is a screenshot of the edit type dialog

[image: Screenshot from 2013-03-08 10:26:39]https://f.cloud.github.com/assets/127259/235987/541d7828-87d2-11e2-9a8b-72b04fbcaeee.png


Reply to this email directly or view it on GitHubhttps://github.com//pull/455#issuecomment-14610873
.

@3nids
Copy link
Member Author

3nids commented Mar 8, 2013

Cool, thanks!

I don't have much time to go further on this, but it might be a good idea to remove the "immutable" type before 2.0.

Do you have any advise on how to achieve this?

  • just remove the edit type and forget about compatibility break
  • change the way of things are saved in the project (ie.e edit type string instead of number) and create a map for key/value related to the enum.
  • ....

NathanW2 added a commit that referenced this pull request Mar 10, 2013
[Feature #6562] add editable option for all edit types
@NathanW2 NathanW2 merged commit ddddbfc into qgis:master Mar 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants