-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server atlas print fix pk-less layers #45521
Conversation
3d71c4a
to
ce2d58d
Compare
@rldhont @pblottiere @dmarteau gentle review ping... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 2 comments
@rldhont comments addressed, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple typo change
Co-authored-by: David Marteau <dmarteau@3liz.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-45521-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 96808065a45747a64235db17649be26b5d23f321,ce2d58d0a78ca76776fb2c9c30f88397356a7df5,6f8bed820b3e50076f308d3e426a871dafc364f9,96187b20c562442d254d907928eb2c1d9bfc9d46
# Push it to GitHub
git push --set-upstream origin backport-45521-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports Then, create a pull request where the |
Fix pk-less layers atlas print #30817