Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form mode save button from attr dialog #45532

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Oct 15, 2021

Fix #45527

@elpaso elpaso added Attribute Table Bug Either a bug report, or a bug fix. Let's hope for the latter! backport queued_ltr_backports Queued Backports labels Oct 15, 2021
@github-actions github-actions bot added this to the 3.22.0 milestone Oct 15, 2021
@nyalldawson
Copy link
Collaborator

Is this a new regression? If not, I'd suggest we defer merging till after 3.22.0 (given the fragility of attribute table/form signal connections and the number of unintended side effects they cause)

@elpaso elpaso added the Frozen Feature freeze - Do not merge! label Oct 18, 2021
@tudorbarascu
Copy link
Member

To me it's a regression IMHO but I understand the fragility of the attribute table. As this should also be backported to 3.16, wouldn't it be better to try it in 3.22 until it reaches LTR status? I'm building the master with this patch anyhow so I'm going to be one of the testers for sure but it would be great if we could have wider testing.

@elpaso
Copy link
Contributor Author

elpaso commented Oct 18, 2021

@tudorbarascu are you sure it's a regression? Did you check if this was working on 3.16?

@gioman
Copy link
Contributor

gioman commented Oct 18, 2021

@elpaso it was first reported by me here #37795 but I don't think it was a regression even then. I should check to be 100% sure.

@nyalldawson nyalldawson added backport release-3_22 and removed Frozen Feature freeze - Do not merge! labels Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attribute Table backport queued_ltr_backports Queued Backports Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing values in Form mode of attribute table doesn't set active the Save button
4 participants