remove QgsSponsors widget. Instead open sponsors page in the webbrowser (fix #16169) #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kuhn
reviewed
May 18, 2017
| sponsors->activateWindow(); | ||
| QgsSettings settings; | ||
| QString qgisSponsorsUrl = settings.value( QStringLiteral( "qgis/qgisSponsorsUrl" ), | ||
| tr( "http://qgis.org/en/site/about/sponsorship.html" ) ).toString(); |
There was a problem hiding this comment.
Does this need to be configurable?
There was a problem hiding this comment.
I think yes, for example for closed networks. Also this done for all other URLs, e.g. bugtracker, homepage
There was a problem hiding this comment.
Ok, please don't forget to mention upstream once in a while despite whitelabeling. Even for closed network customers ;)
|
Thanks for the fix |
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use sponsors list from the website to avoid issues with updating. Fixes https://issues.qgis.org/issues/16169. Backport to 2.18 needed.
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit