Add multi edit attributes icon to the Digitizing toolbar #4584
Conversation
|
Does it make sense here? I thought it was only a attribute table thing
…On Thu, May 18, 2017 at 3:50 PM, Harrissou Sant-anna < ***@***.***> wrote:
The multi edit attributes icon wasn't available in toolbar (fixes #16568)
[image: image]
<https://cloud.githubusercontent.com/assets/7983394/26188266/9ec0c338-3b9e-11e7-841d-40fdfb0284aa.png>
Checklist
Reviewing is a process done by project maintainers, mostly on a volunteer
basis. We try to keep the overhead as small as possible and appreciate if
you help us to do so by completing the following items. Feel free to ask in
a comment if you have troubles with any of them.
- Commit messages are descriptive and explain the rationale for changes
- Commits which fix bugs include fixes #11111 in the commit message
next to the description
- Commits which add new features are tagged with [FEATURE] in the
commit message
- Commits which change the UI or existing user workflows are tagged
with [needs-docs] in the commit message and containt sufficient
information in the commit message to be documented
- I have read the QGIS Coding Standards
<https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html>
and this PR complies with them
- This PR passes all existing unit tests (test results will be
reported by travis-ci after opening this PR)
- New unit tests have been added for core changes
- I have run the scripts/prepare-commit.sh script
<https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTE.md#contributing-to-qgis>
before each commit
------------------------------
You can view, comment on, or merge this pull request online at:
#4584
Commit Summary
- Add multi edit attributes icon to the Digitizing toolbar
File Changes
- *M* src/ui/qgisapp.ui
<https://github.com/qgis/QGIS/pull/4584/files#diff-0> (1)
Patch Links:
- https://github.com/qgis/QGIS/pull/4584.patch
- https://github.com/qgis/QGIS/pull/4584.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4584>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXS3CJ5ZVU5VNBZVOqhuMiNDvsjVdF6ks5r69wtgaJpZM4NewtP>
.
|
|
Same thought, I was under the impression that this was only used through the attribute table, not the main canvas. If that's the case, -1 to further clutter the main canvas window's toolbars. |
|
Actually the attribute table version is (IMO) the inferior version. The one accessed through the menu (which this PR adds to the toolbar) is a faster workflow - make a selection, trigger the action, edit the desired fields. |
|
But I'm also -0 on adding more icons to the cluttered toolbars.. |
|
Indeed, multi edit is currently available from other part than the attribute table: the Edit menu provides such option and honestly I find convenient to have access to this tool without always showing the attribute table once features are selected, particularly from the map canvas). And because it's a quick way to edit multiple fields at once instead of the workaround of "merge attributes of selected features" button, I found it not user friendly to always have to select Edit menu --> "Modify attributes.." For me, it looked like a missing feature. I agree with you that we shouldn't clutter the toolbar but I do not feel it's the case for this one, yet. I guess this impression might also depend on how many toolbars are enabled in the application. An alternative to this could be to set a (default?) shortcut. (would that be enough?) |
|
I'm also -1 on adding more icons to the cluttered toolbars. |
|
Thanks @DelazJ , I think this identifies a weak spot to trigger this action: it requires too much mouse interaction to trigger and is hard to even find. (Example last week someone asked for this feature, I said it's possible and showed it, a day later I received a mail that she couldn't find it on her system. Turns out she was looking in the vector menu). I can imagine a keyboard shortcut for it would be good. And then maybe we can think of a good integration with the identify tool which can already open feature forms. E.g. in the context menu? Other ideas? |
|
In the interest of moving this PR along, and given that discoverability of this feature IS an issue, I'm changing my vote to a +1 (but it needs shifting to after the "new" action - it doesn't belong between the edit and save edits action, and creating new features is much more common). The clutter could be somewhat avoided by moving the "move features" and "vertex tool" to the advanced editing toolbar - I think they both belong better there anyway... |
|
OK to move the button after the new feature one.
I'm not convinced by this option firstly because if you consider the Digitizing toolbar as cluttered, I don't know how we'd qualify the advanced digitizing toolbar with all the buttons and moving the icons there won't solve the issue imho. Then the vertex tool addresses a really common and basic need when digitizing: moving wrong placed vertex and we should not ask user to add the whole advanced toolbar just for this simple task. So, in the case we follow the option above, my proposal would be to place the multiedit button after the spatial tools (keeping them grouped) with the sequence "you draw new features, you edit them spatially and you edit them tabularly" |
Ok - let's lock this in:
|
buttons to the Advanced Digitizing toolbar
|
Done |
|
...And done...! Thanks |
|
@nyalldawson sorry but I'm afraid that the changes I pushed on "move features" buttons are not what we agreed to do and I can't find the right command to move it near the CAD button. 😞 |
The multi edit attributes icon wasn't available in toolbar (fixes #16568)
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit