Preserve attribute type in dialog update #46172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kuhn
added
Bug
m-kuhn
force-pushed
the
preserve_attribute_type_in_dialog_update
branch
from
9b03249
to
ef56bf1
Compare
2 tasks
|
@m-kuhn , a test covering that would be good. |
The simpler the patch, the likelier this request 😆 |
m-kuhn
added
the
Requires Tests!
|
It is quite possible that it was unintentional. |
when they are created in the attribute dialog Fixes qgis#46158
m-kuhn
force-pushed
the
preserve_attribute_type_in_dialog_update
branch
from
ef56bf1
to
fecf05d
Compare
m-kuhn
commented
Nov 23, 2021
| eww->setValue( value ); | ||
| mCurrentFormFeature.setAttribute( eww->field().name(), value ); |
There was a problem hiding this comment.
For reference, this is another unreported issue, live default values were not stored into the current form feature and hence taken into account by any related functionality.
m-kuhn
force-pushed
the
preserve_attribute_type_in_dialog_update
branch
from
fecf05d
to
c1b8722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an attribute is set to "apply on update" and has a complex type (anything that's not losslessly convertible to string and back), QGIS will up to now replace it with an empty value in the attribute form.
This patch simply removes the string conversion.
Fixes #46158