Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression followup #46515 #46931

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Jan 21, 2022

See comment : #46515 (comment)

@elpaso elpaso added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jan 21, 2022
@elpaso elpaso requested a review from troopa81 January 21, 2022 10:51
@github-actions github-actions bot added this to the 3.24.0 milestone Jan 21, 2022
@gioman
Copy link
Contributor

gioman commented Jan 21, 2022

Is this related to #46882 ?

@elpaso
Copy link
Contributor Author

elpaso commented Jan 21, 2022

Yes, exactly, I didn't see #46882 but this should fix #46882

@troopa81
Copy link
Contributor

Does it need also to be fixed here ?

@elpaso
Copy link
Contributor Author

elpaso commented Jan 21, 2022

Does it need also to be fixed here ?

Probably, not sure about how to test it though, can you take care of it?

@troopa81
Copy link
Contributor

@elpaso sure!

@elpaso elpaso merged commit 001d2f6 into qgis:master Jan 21, 2022
@elpaso
Copy link
Contributor Author

elpaso commented Jan 21, 2022

@elpaso sure!

Thank you! This one is merged so you can make a followup PR for the other bit.

@elpaso elpaso deleted the bugfix-followup-pr-46515 branch January 21, 2022 14:44
@elpaso
Copy link
Contributor Author

elpaso commented Jan 21, 2022

@troopa81 forgot to mention how to test, you need to test a raster (I used OSM tiles) with QT_SCREEN_SCALE_FACTORS='DP-0=2;HDMI-0=2;DVI-0=2; env var (change it accordingly to your screens) and also with QT_SCREEN_SCALE_FACTORS='DP-0=1;HDMI-0=1;DVI-0=1; , I also have QT_AUTO_SCREEN_SCALE_FACTOR=0 but I'm not sure it matters.

Also test the canvas magnification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants