Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug/feature?] Improve array_remove_at function #46942

Merged
merged 4 commits into from Jan 31, 2022

Conversation

roya0045
Copy link
Contributor

Description

Fixes an undocumented bug where using a value greater than the array size would return a null value instead of the array.

This works also adds support for using a negative index.

@github-actions github-actions bot added this to the 3.24.0 milestone Jan 21, 2022
@nyalldawson
Copy link
Collaborator

Please confirm that you have built locally and tested this thoroughly and aren't just relying on CI for feedback.

@roya0045
Copy link
Contributor Author

Please confirm that you have built locally and tested this thoroughly and aren't just relying on CI for feedback.

Yup, all is fine and behave as expected. It can be frozen until the new release of you want.

elpaso
elpaso previously requested changes Jan 24, 2022
resources/function_help/json/array_remove_at Outdated Show resolved Hide resolved
resources/function_help/json/array_remove_at Outdated Show resolved Hide resolved
src/core/expression/qgsexpressionfunction.cpp Outdated Show resolved Hide resolved
tests/src/core/testqgsexpression.cpp Show resolved Hide resolved
Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
@nyalldawson nyalldawson enabled auto-merge (rebase) January 31, 2022 02:31
@nyalldawson nyalldawson dismissed elpaso’s stale review January 31, 2022 02:32

comments addressed

@nyalldawson nyalldawson merged commit 3b5e3fc into qgis:master Jan 31, 2022
@roya0045 roya0045 deleted the array_remove_at_negative branch January 31, 2022 17:10
DelazJ added a commit to DelazJ/QGIS-Documentation that referenced this pull request Feb 2, 2022
- add negative index to array_remove_at (qgis/QGIS#46942)
- add new parameters to overlay_intersects (qgis/QGIS#46683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants