reload output layer on successful execution of GDAL rasterize algorithm (fix #45729) #47055
Conversation
alexbruy
added
the
Processing
| continue | ||
|
|
||
| l.dataProvider().reloadData() | ||
| context.temporaryLayerStore().addMapLayer(l) |
There was a problem hiding this comment.
why do we re-add this here? won't it already be in that store?
There was a problem hiding this comment.
It is re-added in order to have an updated layer with the reloaded data. But seems you are right and this line can be safely removed.
There was a problem hiding this comment.
Thanks! Ultimately I think we should consider moving this logic to a function in QgsProcessingContext (something like ::reloadLayersWithPath(....) ), but that's entirely optional 👍
There was a problem hiding this comment.
Actually maybe ::invalidateLayersAtPath(...) is better
There was a problem hiding this comment.
Do you think it should be done as a part of this PR or it is better to do it in a follow-up PR targeted only at master branch?
There was a problem hiding this comment.
Yep, a follow up PR sounds good!
Description
GDAL algorithms "Rasterize (overwrite with fixed value)" and "Rasterize (overwrite with attribute)" alter input raster but does not refresh it. As a result if raster already added to canvas user continues to work with the old "snapshot" of raster layer.
Fixes #45729.