Update wms layer title each time a new layer is selected

[landryb]

previously, if the wms layer title was manually modified, it would never get
updated anymore until qgis was restarted.

Fixes #28858 #40421

Description

the existing behaviour of not updating the field anymore feels like a bug.. and nobody has been able to explain why this choice had been made.

[landryb]

testing wise, i've backported locally the commit on 3.22.3 and:

• checked that upon layer selection the title field was updated
• checked that i could still edit the title field, and if added the layer title was the modified one in the layertree
• checked that after that, upon layer selection the title field was still updated with the selected layer title (eg the previously modified title was overwritten)
• same thing with WMS and WMTS servers (eg with a tiled layer list)

[landryb]

shows the 'new' behaviour

[lbartoletti]

LGTM — test failure is unrelated —, but I'm not a web/server guy. cc @elpaso @pblottiere ?

[landryb]

@elpaso, can you review this or point me at the right developer who should review it ? Thanks !

[jef-n]

That feature predates the unified add layer dialog. So the last layer name would be clean whenever you opened the dialog and you could enter the title and then pick the layer(s) without that resetting the entered title. You could also reuse the existing title to add another (set of) layer(s) - maybe because your entered title also describes the service and not just the layer (introduced in r15681 / 7b4e699)

[Gustry]

@lbartoletti FYI, these 2 backport labels are the same target branch 3.22. One should be removed.
QGIS 3.22 is the new LTR now.

[jef-n]

the updates also resume, when you just clear the field.

[landryb]

the updates also resume, when you just clear the field.

agreed, but that's ... super counter-intuitive, a bit like an easter-egg :)

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[landryb]

can someone merge this ? or is there more to discuss ? thanks!

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[landryb]

@jef-n @nyalldawson is there any reason for not merging this, eg something controversial in the change/fix ? i hate to see those bots marking PRs as stale..