DXF export: fix crash on some MultiPolygon geometries when offset != 0 (fixes #46245) #47277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kuhn
reviewed
Feb 10, 2022
m-kuhn
reviewed
Feb 10, 2022
| Q_ASSERT( polygon ); | ||
| const QgsGeometryCollection *gc = dynamic_cast<const QgsGeometryCollection *>( sourceGeom ); | ||
| Q_ASSERT( gc ); | ||
| if ( gc ) |
There was a problem hiding this comment.
So ... now I'm wondering if we need this check at all, at this point we should be sure we have a gc
There was a problem hiding this comment.
at this point we should be sure we have a gc
I think so, but can't swear :-) The current code should be safe enough: not crashing in production builds, and asserting in debug builds so we can investigate what's going on
There was a problem hiding this comment.
Makes sense. I always lived by the rule after an assert ub is allowed in prod. But not sure that's a common understanding 🤪
m-kuhn
reviewed
Feb 10, 2022
| for ( int i = 0; i < gc->numGeometries(); i++ ) | ||
| const QgsGeometryCollection *gc = dynamic_cast<const QgsGeometryCollection *>( sourceGeom ); | ||
| Q_ASSERT( gc ); | ||
| if ( gc ) |
There was a problem hiding this comment.
Same remark, the if after the assert only makes sense if this is realistic to happen because of some uncontrollable conditions with release builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.