Throw c++ exception when a Python exception occurs while running a algorithm #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonder-sk
approved these changes
Jun 22, 2017
3nids
approved these changes
Jun 22, 2017
| * \ingroup core | ||
| * Custom exception class for processing related exceptions. | ||
| */ | ||
| class CORE_EXPORT QgsProcessingException : public QgsException |
There was a problem hiding this comment.
what about moving QgsException, QgsCsException and QgsProcessingException all to the same header?
they are almost the same and that would be coherent with the sip file.
| @@ -153,6 +153,11 @@ | |||
| #define SIP_CONVERT_TO_SUBCLASS_CODE(code) | |||
|
|
|||
| /* | |||
| * Virtual error handler (/VirtualErrorHandler/) | |||
| */ | |||
| #define SIP_VIRTUALERRORHANDLER(name) | |||
There was a problem hiding this comment.
please also add this to Doxyfile.in
Sorry - I failed here. Just couldn't get the linker happy.
Done |
|
Nice improvement. |
Unfortunately requires a bunch of code to be duplicated from QgsPythonUtilsImpl::getTraceback() into core.sip, but there's no way to avoid this
And auto catch python exceptions and report failure of model
processing are non-fatal. We report them to users, and treat the feature as having no geometry, but don't stop execution.
nyalldawson
force-pushed
the
processing_exception
branch
from
da491b5
to
c3e24b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of building blocks required for catching python exceptions which occur in overriden virtual c++ methods and converting them to a c++ exception which is catchable in c++ code.
It then adds a new QgsProcessingException exception which is thrown when a python exception occurs while running a processing algorithm.