Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge features into an existing one instead of a new one #47822

Merged
merged 2 commits into from Apr 4, 2022

Conversation

domi4484
Copy link
Contributor

@domi4484 domi4484 commented Mar 16, 2022

This aims to fix #47629.

  • Per default the first selected feature will be preserved (other features are merged in)
  • When pressing "Take attributes from selected feature" selected feature will be preserved
  • When pressing "Take attributes from feature with the largest area/longest line" that feature will be preserved

@github-actions github-actions bot added this to the 3.26.0 milestone Mar 16, 2022
@domi4484
Copy link
Contributor Author

@andreasneumann tryng to fix this... What do you mean, what should be the default behavior when opening the merge dialog?
At the moment the "default value clause" is displayed but this does not make sense anymore. Probably it would make more sense to be "Skipped" or the id of the "master" feature.

image

@andreasneumann
Copy link
Member

@andreasneumann tryng to fix this... What do you mean, what should be the default behavior when opening the merge dialog?

I think - as soon as one selects "Take attributes from the selected feature" or "Take attributes from feature with largest area" - then the primary key of the selected or largest feature should be filled in "by default" in the "Merge" record.

Thanks!

@domi4484
Copy link
Contributor Author

I think - as soon as one selects "Take attributes from the selected feature" or "Take attributes from feature with largest area" - then the primary key of the selected or largest feature should be filled in "by default" in the "Merge" record.

Yes when pressing the buttons is quite clear. The question was more about when the dialog is just opened. I guess it would make sense to use the Id of the first selected feature.

@andreasneumann
Copy link
Member

I guess it would make sense to use the Id of the first selected feature.

Yes, this would be fine.

It would also be fine to have "create a new feature id" by default (as it is now).

We just need a way to override this behavior - as this is not possible today.

@nyalldawson
Copy link
Collaborator

This approach looks on track to me 👍

@domi4484 domi4484 marked this pull request as ready for review March 22, 2022 14:58
@3nids 3nids merged commit 2fe712f into qgis:master Apr 4, 2022
@andreasneumann
Copy link
Member

Thanks!

Can this be back-ported to 3.22.x ?

@3nids
Copy link
Member

3nids commented Apr 4, 2022

backporting to 3.24 should be fine.
@nyalldawson what about 3.22?

@nyalldawson
Copy link
Collaborator

@3nids i'm ok for that -- just has to go through the queued branch first

elpaso added a commit to elpaso/QGIS that referenced this pull request Dec 6, 2022
qgis-bot pushed a commit that referenced this pull request Jan 6, 2023
qgis-bot pushed a commit that referenced this pull request Jan 6, 2023
domi4484 pushed a commit to domi4484/QGIS that referenced this pull request Mar 27, 2023
m-kuhn pushed a commit to m-kuhn/QGIS that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive vector merge tool always creating a new feature id instead of preserving the existing one
5 participants