Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revised implementation of #33819 #48375

Closed
wants to merge 3 commits into from
Closed

revised implementation of #33819 #48375

wants to merge 3 commits into from

Conversation

roya0045
Copy link
Contributor

@roya0045 roya0045 commented Apr 28, 2022 •
edited

Description

Removed caching and using the new API.

Basically this just adds the variable on the legend expression builder.

fixes #21988 fixes #33312

@github-actions github-actions bot added the GUI/UX Related to QGIS application GUI or User Experience label Apr 28, 2022
@github-actions github-actions bot added this to the 3.26.0 milestone Apr 28, 2022
@roya0045
Copy link
Contributor Author

roya0045 commented May 5, 2022

Unrelated test failure. @nyalldawson I assume this is what you had in mind for the implementation.

@nyalldawson nyalldawson closed this May 8, 2022
@nyalldawson nyalldawson reopened this May 8, 2022
nyalldawson
nyalldawson reviewed May 8, 2022
View reviewed changes
src/core/expression/qgsexpression.cpp Outdated Show resolved Hide resolved
src/core/layertree/qgslayertreelayer.h Outdated Show resolved Hide resolved
src/core/layertree/qgslayertreelayer.h Outdated Show resolved Hide resolved
src/core/layertree/qgslayertreemodellegendnode.cpp Outdated Show resolved Hide resolved
src/core/layertree/qgslayertreemodellegendnode.cpp Outdated Show resolved Hide resolved
@nyalldawson nyalldawson added the Freeze Exempt Feature Freeze exemption granted label May 12, 2022
@roya0045 roya0045 force-pushed the symbex2 branch 2 times, most recently from 6b01266 to 2c9ee6f Compare May 23, 2022 14:14
@roya0045
Copy link
Contributor Author

Mac build failure is unrelated.

@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 14, 2022
@roya0045
Copy link
Contributor Author

@nyalldawson Did I need to do anything more on my end? Everything seems to work as intended, only the mac build failed.

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 14, 2022
@nyalldawson nyalldawson modified the milestones: 3.26.0, 3.28 (feature) Jun 17, 2022
@nyalldawson nyalldawson removed the Freeze Exempt Feature Freeze exemption granted label Jun 20, 2022
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 4, 2022
@roya0045
Copy link
Contributor Author

roya0045 commented Jul 4, 2022

Fine, awaiting review.

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 5, 2022
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 31, 2022
@roya0045
Copy link
Contributor Author

Same status

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 1, 2022
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 16, 2022
@roya0045
Copy link
Contributor Author

It's still fine.

@roya0045
Copy link
Contributor Author

roya0045 commented Jun 1, 2023

@nyalldawson people seem to be using more and more the legend expression builder, though as expected the paint points are showing up. Merging this would help guide people to a reliable expression to get the value they want in the legend.

@roya0045 roya0045 mentioned this pull request Jun 13, 2023
Merged
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 16, 2023
@roya0045
Copy link
Contributor Author

awaiting review

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 16, 2023
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 1, 2023
@roya0045
Copy link
Contributor Author

roya0045 commented Jul 3, 2023

awaiting review

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 3, 2023
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 18, 2023
@roya0045
Copy link
Contributor Author

awaiting review

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 19, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 3, 2023
@roya0045
Copy link
Contributor Author

roya0045 commented Aug 3, 2023

unstale

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 3, 2023
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 18, 2023
@roya0045
Copy link
Contributor Author

unchanged

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 18, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 2, 2023
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson Awaiting requested review from nyalldawson

Assignees
No one assigned
Labels
GUI/UX Related to QGIS application GUI or User Experience stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Milestone
3.28.0
Development

Successfully merging this pull request may close these issues.

Unable to use aggregate fucntions in Text on Symbol expressions Expression for Map Composer Legend
2 participants
@roya0045 @nyalldawson