[processing] improve rasterize dialog UI, add help #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My finger's on the merge button already 👍 |
m-kuhn
reviewed
Aug 11, 2017
|
|
||
| If both, map theme and layer are not set, the current map content will be rendered. | ||
|
|
||
| The minimum extent entered will internally be extended to be a multiple of the tile sizes. |
m-kuhn
reviewed
Aug 11, 2017
|
|
||
| Alternatively, a single layer can be selected if not map theme is set. | ||
|
|
||
| If both, map theme and layer are not set, the current map content will be rendered. |
There was a problem hiding this comment.
Is this better? "If neither map theme nor the layer is set..."
m-kuhn
reviewed
Aug 11, 2017
| qgis:rasterize: > | ||
| This algorithm rasterizes map canvas content. | ||
|
|
||
| A map theme can be selected to render a predetermined set of layers. |
There was a problem hiding this comment.
... with a defined style for each layer .
|
@m-kuhn , all of your comments were added to the updated commit. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rasterize algorithm's dialog suffered from "extreme wideness" due to long parameter strings. I've moved some of the content into the newly-added help section.
I've also moved the optional parameters below the non-optional ones, feels much more logical and intuitive that way.
Before (left) vs. after (right):
Notice the dialog content being cropped due to wide string, ending up hiding parameters' right-most control buttons
@m-kuhn , @marioba , are you guys OK with this?
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit