Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFS provider] When DescribeFeatureType returns unknown geometry type… #50237

Closed
wants to merge 0 commits into from

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Sep 17, 2022

…, include a large BBOX when requesting single feature to guess it (fixes #49335)

@rouault rouault added the backport queued_ltr_backports Queued Backports label Sep 17, 2022
@github-actions github-actions bot added this to the 3.28.0 milestone Sep 17, 2022
@pathmapper
Copy link
Contributor

pathmapper commented Sep 17, 2022

Nice solution!

Works now as expected:

QGIS 3.26.3

image

This PR

image

(tested with WFS https://xplanung.freiburg.de/xplansyn-wfs/services/xplansynwfs / feature type: xplan:BP_Bereich)

Copy link
Contributor

@pathmapper pathmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the COUNT=1 GetFeature request with this new bbox filter doesn't return a feature should we then send a second one without bbox filter or use the GetFeature request with RESULTTYPE=hits to see if features are available and if yes, as a consequence assign type NoGeometry instead of type Unknown ?

@rouault
Copy link
Contributor Author

rouault commented Sep 19, 2022

If the COUNT=1 GetFeature request with this new bbox filter doesn't return a feature should we then send a second one without bbox filter or use the GetFeature request with RESULTTYPE=hits to see if features are available and if yes, as a consequence assign type NoGeometry instead of type Unknown ?

addressed per fd59e4a

@pathmapper
Copy link
Contributor

addressed per fd59e4a

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WFS] Layer is added incorrectly as mixed geometry collection
2 participants