Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save original layout item picture mode #50277

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

troopa81
Copy link
Contributor

Supersedes #49615

This PR propose to add an original mode different than the one computed by QgsLayoutItemPicture (which could be equal to FormatUnknown if the given picture is missing/invalid), to use it in the UI and save it in the project

I set the since doxy tag to 3.22 because I would like to backport it.

Fixes #49165 (stale and close)
Fixes #47981
Fixes #38031
Fixes #37804

cc @nicogodet

@troopa81 troopa81 added Bug Either a bug report, or a bug fix. Let's hope for the latter! backport release-3_22 labels Sep 21, 2022
@github-actions github-actions bot added this to the 3.28.0 milestone Sep 21, 2022
@github-actions github-actions bot added the GUI/UX Related to QGIS application GUI or User Experience label Sep 21, 2022
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good approach 👍

@nicogodet
Copy link
Member

Sweeeeettttt !
Did a quick test and it seems fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport queued_ltr_backports Queued Backports Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
3 participants