Clipboard Cut&Paste fix when attached special field values. Fixes #16870 #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nyalldawson @elpaso I did a backport of a2c1810 |
|
Thanks @luipir |
m-kuhn
requested changes
Aug 16, 2017
src/app/qgsclipboard.cpp
Outdated
| if ( !geometry ) | ||
| continue; | ||
|
|
||
| QgsFeature feature; | ||
| if ( !fields.isEmpty() ) | ||
| feature.setFields( fields, true ); | ||
|
|
||
| feature.setGeometry( geometry ); | ||
| feature.setGeometry( *geometry ); |
There was a problem hiding this comment.
I think this leaks the geometry.
There was a problem hiding this comment.
fixed... tanks to point out. I read the api too quickly.
luipir
changed the title
luipir
commented
Aug 17, 2017
src/app/qgsclipboard.cpp
Outdated
| if ( !geometry ) | ||
| continue; | ||
|
|
||
| QgsFeature feature; | ||
| if ( !fields.isEmpty() ) | ||
| feature.setFields( fields, true ); | ||
|
|
||
| feature.setGeometry( geometry ); | ||
| feature.setGeometry( *geometry ); |
There was a problem hiding this comment.
fixed... tanks to point out. I read the api too quickly.
m-kuhn
approved these changes
Aug 17, 2017
|
@m-kuhn travis fail on qgis3 but succes on qgis 2.x |
|
tnx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport cherry-pick for a2c1810
resume:
In some cases when features are attached from clipboard as \t separated string, the import failed due the fact that the fromWkt geometry contructor is build on WKT * dumped fields. In some case when some dumped field has values inside parenthesis "(some value") the fromWkt parser return a ZM geometry.
This patch strips the leading field values leaving only WKT to the parser.
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit