Avoid a redundant calculation of visible layer extent in overview canvas #50329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was being called twice immediately in a row, and the first time was skipping the "isVisible" check used before the second call. As a result we were ALWAYS recalculating the full extent of the project with every layer set change, even when the overview canvas was not open (and this is non-trivial for very large projects!) On one test project this reduces a multi-second pause when checking/unchecking layers/groups in the tree to no pause.
nyalldawson
added
Optimization
github-actions
bot
added
the
GUI/UX
nirvn
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was being called twice immediately in a row, and the first time was skipping the "isVisible" check used before the second call. As a result we were ALWAYS recalculating the full extent of the project with every layer set change, even when the overview canvas was not open (and this is non-trivial for very large projects!)
On one test project this reduces a multi-second pause when checking/unchecking layers/groups in the tree to no pause.