Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove auxiliary storage table after removing a vector layer from a p… #50479

Merged
merged 3 commits into from Oct 10, 2022
Merged

Remove auxiliary storage table after removing a vector layer from a p… #50479

merged 3 commits into from Oct 10, 2022

Conversation

pblottiere
Copy link
Member

…roject

Fixes #44667

@pblottiere pblottiere added Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Oct 7, 2022
@pblottiere pblottiere changed the title Remove auxiliary storage table after removing a vector layer from a p… Draft: Remove auxiliary storage table after removing a vector layer from a p… Oct 7, 2022
@pblottiere pblottiere marked this pull request as draft October 7, 2022 14:21
@pblottiere pblottiere changed the title Draft: Remove auxiliary storage table after removing a vector layer from a p… Remove auxiliary storage table after removing a vector layer from a p… Oct 7, 2022
@pblottiere pblottiere removed the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Oct 7, 2022
lbartoletti
lbartoletti approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@lbartoletti lbartoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except a tiny typo.

src/core/project/qgsproject.h Outdated Show resolved Hide resolved
@github-actions github-actions bot added this to the 3.28.0 milestone Oct 8, 2022
@pblottiere pblottiere marked this pull request as ready for review October 10, 2022 07:03
@pblottiere pblottiere merged commit adec434 into qgis:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbartoletti lbartoletti lbartoletti approved these changes

Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Milestone
3.28.0
Development

Successfully merging this pull request may close these issues.

Auxiliary storage and removed layers
2 participants
@pblottiere @lbartoletti