Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OGR provider] querySubLayerList(): use GDAL 3.6.0 OGR_L_GetGeometryTypes() #50491

Merged
merged 2 commits into from Nov 21, 2022
Merged

[OGR provider] querySubLayerList(): use GDAL 3.6.0 OGR_L_GetGeometryTypes() #50491

merged 2 commits into from Nov 21, 2022

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Oct 9, 2022 •
edited

Use OGR_L_GetGeometryTypes() to get the actual geometry types of a layer.

Cf OSGeo/gdal#6491

With it, loading a 1.6 GB GeoPackage of 1.3 million polygon features (with a generic unknown geometry type) goes down from ~ 8 seconds (debug QGIS build + release GDAL build) to 650 ms.

@rouault
[OGR provider] querySubLayerList(): use GDAL 3.6.0 OGR_L_GetGeometryT…
3381c76 
…ypes()

Use OGR_L_GetGeometryTypes() to get the actual geometry types of a
layer.

Cf OSGeo/gdal#6491
@rouault rouault marked this pull request as draft October 9, 2022 21:22
@github-actions github-actions bot added this to the 3.28.0 milestone Oct 9, 2022
@rouault rouault modified the milestones: 3.28.0, 3.30.0 Oct 23, 2022
@rouault
Copy link
Contributor Author

rouault commented Oct 23, 2022

ready for review. GDAL pull request has been merged

@rouault rouault marked this pull request as ready for review October 23, 2022 12:41
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 7, 2022
@rouault
Copy link
Contributor Author

rouault commented Nov 7, 2022

keep alive

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 7, 2022
@nyalldawson nyalldawson reopened this Nov 21, 2022
@rouault rouault merged commit 27f87d1 into qgis:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.30.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rouault @nyalldawson