Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include type name in message about unsupported qfield validations #50589

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Include type name in message about unsupported qfield validations #50589

merged 2 commits into from
Oct 20, 2022

Conversation

strk
Copy link
Contributor

@strk strk commented Oct 18, 2022

Just a very small enhancement to print the type of the QField wer'e unable to validate.
Will help reducing debugging time ( see #49380 (comment) )

@github-actions github-actions bot added this to the 3.28.0 milestone Oct 18, 2022
@strk
Copy link
Contributor Author

strk commented Oct 19, 2022

I've merged these changes in #50592 so if that one is merged we don't need this one

@nyalldawson nyalldawson merged commit 05c2322 into qgis:master Oct 20, 2022
@strk
Copy link
Contributor Author

strk commented Oct 20, 2022

Please don't merge PRs with non-green CI unless CI is known to be broken and tests were run locally first
(I had the tests updated in my #50592 PR, as mentioned in previous comment).

Now the fix for tests is in #50618

@strk strk deleted the improved-debug branch October 20, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.28.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@strk @nyalldawson