Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Select Within Distance" icon to the Selection Toolbar #50679

Closed
wants to merge 2 commits into from

Conversation

tudorbarascu
Copy link
Member

The title says it all. I think it's important to see the Select Within Distance option alongside the Select By Location one.

toolbar

@github-actions github-actions bot added this to the 3.30.0 milestone Oct 25, 2022
@nicogodet
Copy link
Member

Could this be added to a button menu along "Select by location" ?
Instead of overloading toolbar ?

@tudorbarascu
Copy link
Member Author

Could this be added to a button menu along "Select by location" ? Instead of overloading toolbar ?

Thought about it but it's simpler to check opinions before trying to make it work :). Thank you.

@lbartoletti
Copy link
Member

Could this be added to a button menu along "Select by location" ? Instead of overloading toolbar ?

+1 for me.

@uclaros
Copy link
Contributor

uclaros commented Oct 25, 2022

+1 from me too, and to be honest, I preferred the first version of your icon too... This one does not imply within distance imho.

@tudorbarascu
Copy link
Member Author

How does this look? Hope it's good
image

@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 22, 2022
@tudorbarascu
Copy link
Member Author

tudorbarascu commented Nov 25, 2022

Hey :). Do I need to do something more here? Thank you!

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 25, 2022
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 10, 2022
@github-actions
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants