[QgsQuick] Add moveTo animation to qgsquick map canvas #50810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2022
nirvn
reviewed
Nov 7, 2022
| @@ -330,7 +387,7 @@ Item { | |||
| target: null | |||
| grabPermissions: PointerHandler.CanTakeOverFromHandlersOfDifferentType | PointerHandler.ApprovesTakeOverByItems | |||
|
|
|||
| onWheel: { | |||
| onWheel: function( event ) { | |||
There was a problem hiding this comment.
@tomasMizera , I see you have met Qt6's wise decision to put an end to parameter injections into QML :)
There was a problem hiding this comment.
Yeah, took us a lot of time to find all the occurrences though :)
| @@ -343,4 +400,8 @@ Item { | |||
| userInteractedWithMap() | |||
| } | |||
| } | |||
|
|
|||
| QgsQuick.QgsQuickUtils { | |||
There was a problem hiding this comment.
IMHO, I'd go down the road of a singleton right away, it's really meant to be used in other places too and making it a singleton from the get go will be more inviting for others to append useful stuff there.
There was a problem hiding this comment.
Makes sense, it is now a singleton class
|
@tomasMizera , can you address the failing CIs? |
tomasMizera
force-pushed
the
qgsquick/moveto-mapcanvas-animation
branch
from
2e457d4
to
178b28b
Compare
|
@nirvn done now |
|
@nirvn if you are happy, we will merge this on Monday? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #50271 as that one was closed because of inactivity (Sorry for that @nirvn and thanks for the review!).
PR adds animation to interactively move the map canvas and addresses comments from the previous PR.
It also adds a new utils class to be used from QML (it could be a singleton in the future if we use it in multiple places).
This is how it looks in Mergin Maps 馃檪
20221107114053248.mp4