symbols: rename material to material settings #50977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mMaterial is not a material but an attribute to handle material settings. Renaming it makes it easier to understand its usage.
See previous commit.
mMaterial is not a material but an attribute to handle material settings. Renaming it makes it easier to understand its usage.
See previous commit.
mMaterial is not a material but an attribute to handle material settings. Renaming it makes it easier to understand its usage.
ptitjano
force-pushed
the
rename-mmaterial
branch
from
a00d6fd
to
13df088
Compare
ptitjano
changed the title
ptitjano
force-pushed
the
rename-mmaterial
branch
from
13df088
to
ee954f3
Compare
See previous commit.
mMaterial is not a material but an attribute to handle material settings. Renaming it makes it easier to understand its usage.
See previous commit.
ptitjano
force-pushed
the
rename-mmaterial
branch
from
ee954f3
to
d13651b
Compare
nyalldawson
reviewed
Nov 23, 2022
wonder-sk
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mMaterialis not a material but an attribute to handle materialsettings. Renaming it makes it easier to understand its usage.
cc @wonder-sk @benoitdm-oslandia