Fix generate_console_pap.py script

[nyalldawson]

This script was still using Qt4 QApplication constructor.

I'm not sure how/whether this script is still in use. @jef-n do you have any insights here? How are the api files generated for the release packages now?

[m-kuhn]

Are all these hardcoded paths in this script reasonable?

[jef-n]

Hi Nyall,

On Tue, 10. Jan 2023 at 14:19:44 -0800, Nyall Dawson wrote: This script was still using Qt4 QApplication constructor. How are the api files generated for the release packages now?

Hm, apparently not at all. They are installed and included as is. Jürgen

…

-- Jürgen E. Fischer norBIT GmbH Tel. +49-4931-918175-31 Dipl.-Inf. (FH) Rheinstraße 13 Fax. +49-4931-918175-50 Software Engineer D-26506 Norden https://www.norbit.de QGIS release manager (PSC) Germany IRC: jef on Libera|OFTC norBIT Gesellschaft fuer Unternehmensberatung und Informationssysteme mbH Rheinstrasse 13, 26506 Norden GF: Juergen Fischer, Nils Kutscher HR: Amtsgericht Aurich HRB 100827 Datenschutzerklaerung: https://www.norbit.de/83/

[jef-n]

Hi Nyall,

On Sat, 21. Jan 2023 at 12:22:34 -0800, Jürgen Fischer wrote: Hm, apparently not at all. They are installed and included as is.

Looks like that's not needed at all anymore. The console builds the pap from the apis at runtime. Jürgen

…

-- Jürgen E. Fischer norBIT GmbH Tel. +49-4931-918175-31 Dipl.-Inf. (FH) Rheinstraße 13 Fax. +49-4931-918175-50 Software Engineer D-26506 Norden https://www.norbit.de QGIS release manager (PSC) Germany IRC: jef on Libera|OFTC norBIT Gesellschaft fuer Unternehmensberatung und Informationssysteme mbH Rheinstrasse 13, 26506 Norden GF: Juergen Fischer, Nils Kutscher HR: Amtsgericht Aurich HRB 100827 Datenschutzerklaerung: https://www.norbit.de/83/

[nyalldawson]

Thanks @jef-n !

Looks like that's not needed at all anymore. The console builds the pap
from the apis at runtime.

Does this work for you in a custom build? I think there's something broken with the non-release builds there. I'll look into it, but I'm curious if it's working for you...

[nyalldawson]

@jef-n

Looks like that's not needed at all anymore. The console builds the pap from the apis at runtime.

I don't think this is actually the case anymore -- there's logic in the "console_compile_apis.py" to prepare a pap file, but that's all manual user operations and not done by default.

By default we are only hitting https://github.com/qgis/QGIS/blob/master/src/gui/codeeditors/qgscodeeditorpython.cpp#L122 , which loads the file from https://github.com/qgis/QGIS/blob/master/python/qsci_apis/pyqgis.pap, which hasn't been updated in 4 years...

[YoannQDQ]

Out of curiosity, how are the input .api files created? They seem obsolete.

[nyalldawson]

@YoannQDQ
see #51576 (comment)