Fix move and rotation map tools preview when layer crs != canvas crs #51445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't it expensive to do a feature request and iteration on each update? If it's negligible or there's no way around, fine. Otherwise I would assume that creating a single entity and just moving it around would be more efficient, instead of refetching the data and transforming it? |
|
You're probably right. I had no visible performance issue with my data, but they were extrememely simple polygons. I'll update the PR when I have the time. |
3nids
reviewed
Jan 27, 2023
Comment on lines
-56
to
-57
| mRubberBand->updatePosition(); | ||
| mRubberBand->update(); |
There was a problem hiding this comment.
If I'm not mistaken, setTranslationOffset already updates the rubberband, making the call to updatePosition and update redundant.
YoannQDQ
force-pushed
the
fix-move-rotate-tool-preview
branch
from
bf396b5
to
da9df38
Compare
3nids
approved these changes
Feb 21, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Rotate Feature and Move Feature maptools previews, when the layer crs is not the same as the map canvas destination crs.
Current behavior
Fixed behavior