Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OAPIF] Work around a bug in a server implementation (fixes #51663) #51671

Merged
merged 1 commit into from Feb 23, 2023

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Jan 31, 2023

Cf comment #51663 (comment) for detailed analysis

@rouault rouault added the backport queued_ltr_backports Queued Backports label Jan 31, 2023
@github-actions github-actions bot added this to the 3.30.0 milestone Jan 31, 2023
Copy link
Contributor

@domi4484 domi4484 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I am just wondering what is the advantage of using a unique_ptr for collectionRequest?

@rouault
Copy link
Contributor Author

rouault commented Feb 1, 2023

I am just wondering what is the advantage of using a unique_ptr for collectionRequest?

just to be able to re-assign the variable when retrying. QgsOapifCollectionRequest has no copy assignment operator

@domi4484
Copy link
Contributor

domi4484 commented Feb 1, 2023

I am just wondering what is the advantage of using a unique_ptr for collectionRequest?

just to be able to re-assign the variable when retrying. QgsOapifCollectionRequest has no copy assignment operator

Ok thanks for the explanation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants