Avoid redo-ing the legend symbol hit test for legend edits which won't affect the legend symbols visible in a map #51681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
won't affect the legend symbols visible in a map Avoids a lot of unnecessary expensive work, which can result in very slow edits to eg legend item text Refs qgis#51455 Refs qgis#50905
nyalldawson
force-pushed
the
faster_legend_text_edit
branch
from
8e6f84a
to
ebdac25
Compare
nirvn
approved these changes
Feb 6, 2023
|
@nyalldawson Could this be the culprit of the regression described in #52261 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids a lot of unnecessary expensive work, which can result in very slow edits to eg legend item text
Refs #51455
Refs #50905