Fix broken filter on Relation Editor #51914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen the layer persists. With this there is the current and valid FeatureRequest set on QgsFilteredSelectionManager and this fixes the brocken selection in the RelationEditor.
|
Would be great when you can have a look at it @troopa81 |
|
I'm away from keyboard for the next week. If nobody steps in the mean time, I would take a look when I come back. |
troopa81
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreates the
QgsFilteredSelectionManageron request-change, when the layer persists. With this there is the current and validFeatureRequestset onQgsFilteredSelectionManagerand this fixes the broken filter in the Relation Editor.Bug
In the Attribute Table you could not select the child features anymore in the Relation Editor from the second feature.
Video:
selectionnotconsideredinfilter.webm
The feature got selected, but because it has not been considered in the QgsFilteredSelectionManager it was neither "yellow" nor the buttons reacted accordingly.
LTR has not been affected