Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using interpolated line symbol layer for polygon outlines #52030

Merged
merged 2 commits into from Feb 27, 2023
Merged

Fix using interpolated line symbol layer for polygon outlines #52030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e477d3
Fix using interpolated line symbol layer for polygon outlines
nyalldawson Feb 27, 2023
2daa8b0
Use QgsDoubleSpinBox
nyalldawson Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions python/core/auto_generated/symbology/qgsinterpolatedlinerenderer.sip.in
View file
Open in desktop
Expand Up @@ -340,8 +340,6 @@ Creates the symbol layer

virtual void renderPolyline( const QPolygonF &points, QgsSymbolRenderContext &context );

virtual bool isCompatibleWithSymbol( QgsSymbol *symbol ) const;

virtual bool canCauseArtifactsBetweenAdjacentTiles() const;


Expand Down
5 changes: 0 additions & 5 deletions src/core/symbology/qgsinterpolatedlinerenderer.cpp
View file
Open in desktop
Expand Up @@ -1215,11 +1215,6 @@ void QgsInterpolatedLineSymbolLayer::renderPolyline( const QPolygonF &points, Qg
}
}

bool QgsInterpolatedLineSymbolLayer::isCompatibleWithSymbol( QgsSymbol *symbol ) const
{
return symbol && symbol->type() == Qgis::SymbolType::Line;
}

bool QgsInterpolatedLineSymbolLayer::canCauseArtifactsBetweenAdjacentTiles() const
{
return true;
Expand Down
1 change: 0 additions & 1 deletion src/core/symbology/qgsinterpolatedlinerenderer.h
View file
Open in desktop
Expand Up @@ -302,7 +302,6 @@ class CORE_EXPORT QgsInterpolatedLineSymbolLayer : public QgsLineSymbolLayer
void startFeatureRender( const QgsFeature &feature, QgsRenderContext &context ) override;
void stopFeatureRender( const QgsFeature &feature, QgsRenderContext &context ) override;
void renderPolyline( const QPolygonF &points, QgsSymbolRenderContext &context ) override;
bool isCompatibleWithSymbol( QgsSymbol *symbol ) const override;
bool canCauseArtifactsBetweenAdjacentTiles() const override;

/**
Expand Down
12 changes: 6 additions & 6 deletions src/ui/symbollayer/qgsinterpolatedlinesymbollayerwidgetbase.ui
View file
Open in desktop
Expand Up @@ -88,13 +88,13 @@
<number>6</number>
</property>
<item row="1" column="1" colspan="3">
<widget class="QgsFieldExpressionWidget" name="mWidthEndFieldExpression"/>
<widget class="QgsFieldExpressionWidget" name="mWidthEndFieldExpression" native="true"/>
</item>
<item row="0" column="1" colspan="3">
<widget class="QgsFieldExpressionWidget" name="mWidthStartFieldExpression"/>
<widget class="QgsFieldExpressionWidget" name="mWidthStartFieldExpression" native="true"/>
</item>
<item row="6" column="1" colspan="2">
<widget class="QDoubleSpinBox" name="mDoubleSpinBoxMinWidth">
<widget class="QgsDoubleSpinBox" name="mDoubleSpinBoxMinWidth">
<property name="maximum">
<double>999999.989999999990687</double>
</property>
Expand Down Expand Up @@ -171,7 +171,7 @@
</layout>
</item>
<item row="7" column="1" colspan="2">
<widget class="QDoubleSpinBox" name="mDoubleSpinBoxMaxWidth">
<widget class="QgsDoubleSpinBox" name="mDoubleSpinBoxMaxWidth">
<property name="maximum">
<double>999999.989999999990687</double>
</property>
Expand Down Expand Up @@ -320,7 +320,7 @@
</widget>
</item>
<item row="0" column="1" colspan="2">
<widget class="QgsFieldExpressionWidget" name="mColorStartFieldExpression"/>
<widget class="QgsFieldExpressionWidget" name="mColorStartFieldExpression" native="true"/>
</item>
<item row="1" column="0">
<widget class="QLabel" name="label_10">
Expand Down Expand Up @@ -367,7 +367,7 @@
<widget class="QLineEdit" name="mLineEditColorMaxValue"/>
</item>
<item row="1" column="1" colspan="2">
<widget class="QgsFieldExpressionWidget" name="mColorEndFieldExpression"/>
<widget class="QgsFieldExpressionWidget" name="mColorEndFieldExpression" native="true"/>
</item>
</layout>
</widget>
Expand Down