[Python Console] Fix duplicated newline on save (windows) #52188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When saving a python script on Windows, newlines are duplicated.
This was introduced by #51913
On Windows, QScintilla inserts
\r\n
whenever the enter key is pressed. Code was previously reliant on thecodecs.open
, whose default handling of newlines differs from the wayio.open
,open
, orPath
does it.This PR replaces the calls to
Note: Path did not introduce the
newline
argument until Python 3.10 so we cannnot use it in this case.